Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RSK support to Bitcore Wallet Client #3300

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

alepc253
Copy link

@alepc253 alepc253 commented Nov 8, 2021

No description provided.

@@ -2515,7 +2517,7 @@ export class API extends EventEmitter {
// * @return {Callback} cb - Return error (if exists) and nonce
// */
getNonce(opts, cb) {
$.checkArgument(opts.coin == 'eth', 'Invalid coin: must be "eth"');
$.checkArgument(opts.coin == 'eth' || opts.coin == 'rsk' || opts.coin == 'rbtc', 'Invalid coin: must be "eth"');
Copy link
Author

@alepc253 alepc253 Nov 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, I'm using both RSK and RBTC because I detected in the frontend an assumption that "chain" and "coin" are the same and this is not true for RSK (RSK is the chain and RBTC the coin/native ticker)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant