Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
package.json
includes an "engines" field declaring a requirement for node 16.15.1.If you start an empty project with the following package.json:
running node 18, you will receive the following warning:
As the
@bitmovin/player-integration-yospace
package is mostly intended to run on browsers and video-playing-environments, theres no actual requirement for consumers of this package to have a specific version of node. In fact, if you have any version of node apart from 16.15.1 specifically, npm will report that warning.If using
yarn
, the error is more fatal:When installing this own package for development purposes and during test runs in CI, you also see the same warning as this project itself uses node 18 as defined in it's
.nvmrc
:The engines field isn't relevant for this project, as the nvmrc file determine what version of node someone developing this package should use, and the version of node that a consumer happens to use to install the project has no relevance on the actual runtime expected from this package.
If there is somehow a requirement for clients to use specific versions of node, the engine field should be updated to be either:
"node": "~16.15.1"
(for node 16 specifically)"node": ">16.15.1"
(for node 16 and above)