Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Landscape fullscreen example #170

Merged
merged 7 commits into from
Jul 28, 2023
Merged

Conversation

matamegger
Copy link
Contributor

@matamegger matamegger commented Jul 27, 2023

A example that directly goes into landscape fullscreen mode.

@matamegger matamegger self-assigned this Jul 27, 2023
@matamegger matamegger changed the base branch from development to player_view_fullscreen_api July 27, 2023 14:05
@matamegger matamegger force-pushed the landscape_fullscreen_example branch from 2f5de17 to 7250ed1 Compare July 27, 2023 14:18
@matamegger matamegger marked this pull request as ready for review July 27, 2023 14:23
Copy link
Contributor

@rolandkakonyi rolandkakonyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I manually tested it on both iOS and Android and works like a charm.
Please see my only comment.

@rolandkakonyi
Copy link
Contributor

@matamegger Another question: did you plan on extending our fullscreen implementation guide for RN here?

I am already working on updates for this, you can see the suggestion preview here or the diff here.

@matamegger
Copy link
Contributor Author

@matamegger Another question: did you plan on extending our fullscreen implementation guide for RN here?

I am already working on updates for this, you can see the suggestion preview here or the diff here.

Yes, the idea is to extend the guide as well :)

Base automatically changed from player_view_fullscreen_api to development July 28, 2023 12:17
@matamegger matamegger merged commit 2bb2132 into development Jul 28, 2023
4 checks passed
@matamegger matamegger deleted the landscape_fullscreen_example branch July 28, 2023 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants