Clear search input fix

[pavelpugachh]

Clear search input only if value exists not to trigger valueChanges

[melroy89]

As long as we don't cause regression on my code I'm fine with it. :P

this.transaction_ledger_id_filter.valueChanges
.pipe(
  tap(() => (this.searching = true)),
  takeUntil(this.onDestroy),
  debounceTime(100),
  switchMap((search) => {
    if (search) {
      return this.ledgerService.search(search)
    } else {
      if (this.transaction.transaction_ledger_id) {
        return this.ledgerService.getOne(this.transaction.transaction_ledger_id).pipe(map((ledger) => [ledger]))
      } else {
        return this.ledgerService.getAll()
      }
    }
  }),
  takeUntil(this.onDestroy)
)
.subscribe({
  next: (filteredLegers) => {
    this.searching = false
    this.ledgers.next(filteredLegers)
  },
  error: (error) => {
    console.error(error)
    this.searching = false
  }
})

[macjohnny]

Its unclear to me why this is needed.
@pavelpugachh can you elaborate the scenario this fixes?

[pavelpugachh]

Without this valueChanges is triggered when I click on a field and close it without selecting anything. It’s already empty, value doesn’t change. Пн, 22 апр. 2024 г. в 09:42, Esteban Gehring ***@***.***>:

…

Its unclear to me why this is needed. @pavelpugachh <https://github.com/pavelpugachh> can you elaborate the scenario this fixes? — Reply to this email directly, view it on GitHub <#430 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BBRQAJUAP6BS3VK6DQDT64TY6SWMVAVCNFSM6AAAAAA2Z5RFS6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRYGYYDIMJRHA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[macjohnny]

@pavelpugachh thanks for the explanation. i would suggest to move the check to the _reset method, wdyt?

[pavelpugachh]

Sure, that would be better :) Пн, 22 апр. 2024 г. в 10:09, Esteban Gehring ***@***.***>:

…

@pavelpugachh <https://github.com/pavelpugachh> thanks for the explanation. i would suggest to move the check to the _reset method, wdyt? — Reply to this email directly, view it on GitHub <#430 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BBRQAJWKICPFTBAHPS67JFLY6SZSRAVCNFSM6AAAAAA2Z5RFS6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRYGY2DINBWGY> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[melroy89]

Any update?