Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter code reuse #372

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

wokier
Copy link

@wokier wokier commented Apr 13, 2022

Hi
I suggest you those classes that remove the boilerplate code needed to use the component.
I have first done it for angular 8 but not changes were required.

@macjohnny
Copy link
Member

thanks for your contribution
this is a large code change, I will need to find some time to review it

@wokier
Copy link
Author

wokier commented May 11, 2022

.Hi
It would be nice to have it in next release for an angular 13 version.
The methods init and destroy of the model may be more integrated with the component itself.

@@ -2,7 +2,7 @@
"compileOnSave": false,
"compilerOptions": {
"downlevelIteration": true,
"module": "es2020",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we want to go back to es2015?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants