docs: add taproot multiSign to example list #2125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jasonandjay
commented
Jul 10, 2024
jasonandjay
commented
- taproot OP_CHECKSIG script-path
- taproot OP_CHECKSEQUENCEVERIFY script-path
- taproot OP_CHECKSIGADD script-path
|
When CI performs audit, a new case 1098094 will be encountered Mocha has upgraded brace to 3.0.3 to solve these problems So I upgraded mocha and removed the previous 1097496 temporary solution |
junderw
reviewed
Jul 10, 2024
README.md
Outdated
Comment on lines
128
to
131
| - [Taproot Key Spend](https://github.com/bitcoinjs/bitcoinjs-lib/blob/master/test/integration/taproot.spec.ts#L20-L218) | ||
| - [Create (and broadcast via 3PBP) a taproot script-path spend Transaction - OP_CHECKSIG](https://github.com/bitcoinjs/bitcoinjs-lib/blob/master/test/integration/taproot.spec.ts#L220-L337) | ||
| - [Create (and broadcast via 3PBP) a taproot script-path spend Transaction - OP_CHECKSEQUENCEVERIFY](https://github.com/bitcoinjs/bitcoinjs-lib/blob/master/test/integration/taproot.spec.ts#L339-L441) | ||
| - [Create (and broadcast via 3PBP) a taproot script-path spend Transaction - OP_CHECKSIGADD (3-of-3)](https://github.com/bitcoinjs/bitcoinjs-lib/blob/master/test/integration/taproot.spec.ts#L443-L529) |
There was a problem hiding this comment.
These line numbers might change. When creating line links it needs to point to a stable branch or commit hash.
I would rather just remove the line numbers. People can search within the page.
There was a problem hiding this comment.
Yes, line numbers can bring convenience with more maintenance costs.
junderw
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.