Code

Refactor file store#1684

Code

Open

nymius wants to merge 10 commits intobitcoindevkit:masterbitcoindevkit/bdk:masterfrom nymius:bugfix/i-1517-store-append-after-open-causes-overwritenymius/bdk:bugfix/i-1517-store-append-after-open-causes-overwriteCopy head branch name to clipboard

+338-289

Commits

Commits on Dec 19, 2024

• fix(store): replace Path.exists by OpenOptions.create_new

  Show description for a507877
  nymius

  committed
  a507877

  Copy full SHA for a507877

• feat(store): add Bincode error variant to FileError enum

  nymius

  committed
  d7c3ec5

  Copy full SHA for d7c3ec5

Commits on Dec 23, 2024

• refactor(store)!: change Store's method and error names

  Show description for 1677b02
  nymius

  committed
  1677b02

  Copy full SHA for 1677b02

• doc(README): add "not intended for production" notice in file store

  nymius

  committed
  a2af131

  Copy full SHA for a2af131

• style(store): remove extra Send + Sync bounds on C generic over changesets

  

  ValuedMammal

  authored and

  nymius

  committed
  6d6f8ff

  Copy full SHA for 6d6f8ff

• doc(store): fix grammar in append method documentation

  

  ValuedMammal

  authored and

  nymius

  committed
  5a9a578

  Copy full SHA for 5a9a578

• refactor(store): remove NamedTempFile import in tests

  

  ValuedMammal

  authored and

  nymius

  committed
  6167df1

  Copy full SHA for 6167df1

• refactor(wallet): change structured assignment by tuple indexing to get value

  

  ValuedMammal

  authored and

  nymius

  committed
  91b5cdb

  Copy full SHA for 91b5cdb

• refactor: swap position of tuple values returned by Store::load

  nymius

  committed
  3b695ce

  Copy full SHA for 3b695ce

• test(store): fix typo in comment in last_write_is_short test

  nymius

  committed
  18aa75e

  Copy full SHA for 18aa75e