-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TxBuilder APIs #611
Merged
thunderbiscuit
merged 7 commits into
bitcoindevkit:master
from
thunderbiscuit:feature/add-txbuilder-apis
Nov 26, 2024
+292
−4
Merged
Add TxBuilder APIs #611
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
c6cbfb9
feat: expose TxBuilder::add_data method
thunderbiscuit cfc0308
feat: expose TxBuilder::current_height
thunderbiscuit 99adbf7
feat: expose TxBuilder::nlocktime
thunderbiscuit 465dbeb
feat: expose TxBuilder::allow_dust
thunderbiscuit d0bec77
feat: expose TxBuilder::version
thunderbiscuit ee80d5d
docs: add docstrings for TxBuilder
thunderbiscuit 4f702eb
docs: add docstrings for BumpFeeTxBuilder
thunderbiscuit File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reviewing commit by commit, this looks good, I wrote a test for it and it passed ✅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You sir are building good tests. Do you want to maybe add them as a commit to this PR? I'd merge that for sure.