Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BIP85: update status to Final #1676

Merged
merged 1 commit into from
Oct 25, 2024
Merged

Conversation

scgbckbone
Copy link
Contributor

Moving this BIP to final stage as this is widely deployed

@jonatack jonatack changed the title change BIP85 status to Final BIP85: update status to Final Oct 5, 2024
@jonatack
Copy link
Member

jonatack commented Oct 5, 2024

ACK b012550

For context, this change was recommended yesterday in #1600 (comment).

BIP author @ethankosakovsky has been unresponsive for a long time but would be good to see community feedback here.

@nvk
Copy link

nvk commented Oct 5, 2024

ACK

1 similar comment
@Rob1Ham
Copy link

Rob1Ham commented Oct 5, 2024

ACK

@RandyMcMillan
Copy link
Contributor

ACK b012550

1 similar comment
@luisschwab
Copy link

ACK b012550

| [[bip-0085.mediawiki|85]]
| Applications
| Deterministic Entropy From BIP32 Keychains
| Ethan Kosakovsky
| Informational
| Draft
| Final
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why Final and not Proposed per this comment?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment states "propsed or final", this BIP should be final as it is widely deployed and used by many projects.

@jonatack
Copy link
Member

jonatack commented Oct 7, 2024

Waiting for #1679 outcome before merge here.

@jonatack jonatack merged commit 17c04f9 into bitcoin:master Oct 25, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants