Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BIP78: Allow mixed inputs Redux #1605

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

BIP78: Allow mixed inputs Redux #1605

wants to merge 3 commits into from

Commits on Jul 8, 2024

  1. BIP78: Allow mixed inputs 

    Disallowing mixed inputs was based on incorrect assumption that no
wallet supports mixed inputs and thus mixed inputs imply PayJoin.
However there are at least three wallets supporting mixed inputs.
(Confirmed: Bitcoin Core, LND, Coinomi) Thus it makes sense to enable
mixed inputs to avoid a payjoin-specific fingerptint. To avoid
compatibility issues a grace period is suggested.

Co-authored-by: Martin Habovstiak <[email protected]>
    @DanGould @Kixunil
    DanGould and Kixunil committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    539fd85 View commit details
    Browse the repository at this point in the history

  2. BIP78: Clarify output substitution 

    The original text is ambiguous to allowing transaction cut-through
or not. Transaction cut-through enables savings by posting multiple
transaction intents through a single 2-party payjoin and is used
in practice in payjoins today. Let's explicitly allow it in the text.

Co-authored-by: Martin Habovstiak <[email protected]>
    @DanGould @Kixunil
    DanGould and Kixunil committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    72d8bb0 View commit details
    Browse the repository at this point in the history

  3. BIP78: Doc amount parameter not required 

    It's an optional parameter in BIP 21 Bitcoin URIs, but it doesn't hurt
to make it explicit.

Co-authored-by: Martin Habovstiak <[email protected]>
    @DanGould @Kixunil
    DanGould and Kixunil committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    bd01a26 View commit details
    Browse the repository at this point in the history