Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync to upstream #9

Open
wants to merge 5 commits into
base: bitcoin-fork
Choose a base branch
from

Commits on Sep 6, 2024

  1. Configuration menu
    Copy the full SHA
    9d0fb14 View commit details
    Browse the repository at this point in the history
  2. Fix invalid pointer casts in arm64 implementation (google#65)

    * Fix invalid pointer casts in arm64 implementation
    
    It is UB in C and C++ to type-pun pointers in this way, for two reasons.
    First, casting to a pointer is forbidden if the pointer is not aligned.
    Second, this kind of type-punning is a strict aliasing violation.
    
    Instead, the way to read 8 bytes as a time as a uint64_t is to call
    memcpy. Compilers recognize this pattern and optimize it, lowering it to
    the same code, but without breaking the language's abstract state
    machine.
    
    This is needed to fix some UBSan warnings in Chromium.
    
    * Use crc32c_read_le.h instead
    
    In doing so, I fixed up crc32c_read_le.h a bit:
    
    1. The documentation and tests say the buffers need to be aligned, but
       they don't.
    
    2. Add a 16-bit version.
    
    3. Remove an unnecessary static_cast<uint8_t>. The pointer is already
       uint8_t.
    
    4. Replace the necessary static_casts with uintN_t{x} per the Google
       style guide. https://google.github.io/styleguide/cppguide.html#Casting
    davidben authored Sep 6, 2024
    Configuration menu
    Copy the full SHA
    d3d60ac View commit details
    Browse the repository at this point in the history
  3. #ifdef -> #if defined()

    pwnall committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    1c51f87 View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2024

  1. Configuration menu
    Copy the full SHA
    46abfb7 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    38a132c View commit details
    Browse the repository at this point in the history