MISC: Add error cause to exceptionAlert and Recovery mode #1772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Before you decide on this, test the result of error.toString(), which IIRC is different than String(error). You'll also want to look at the results on both Chrome and Firefox, since they have distinctly different error logging. |
|
Test code: /** @param {NS} ns */
export async function main(ns) {
ns.clearLog();
const error1 = new Error("error1");
const error2 = new Error("error2", { cause: error1 });
const error3 = "error3";
ns.print(`error1: String constructor: ${String(error1)}`);
ns.print(`error2: String constructor: ${String(error2)}`);
ns.print(`error3: String constructor: ${String(error3)}`);
ns.print(`error1: toString(): ${error1.toString()}`);
ns.print(`error2: toString(): ${error2.toString()}`);
ns.print(`error3: toString(): ${error3.toString()}`);
}Chrome: Firefox: The difference between Chrome and Firefox shows up when we use /** @param {NS} ns */
export async function main(ns) {
ns.clearLog();
const error1 = new Error("error1");
const error2 = new Error("error2", { cause: error1 });
ns.print(`error1.stack: ${error1.stack}`);
ns.print(`error2.stack: ${error2.stack}`);
}Chrome: Firefox: Some non-standard properties are implemented by only Firefox (e.g., columnNumber, fileName, lineNumber). |
d0sboots
reviewed
Nov 12, 2024
|
You get a nicely formatted error with both the message, stack, and cause, if you directly |
|
I guess that other function turned out not to be relevant? |
|
I checked that code (
|
catloversg
deleted the
pull-request/misc/add-error-cause-to-exceptionAlert-and-Recovery-mode
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's check this code:
Example output:
Without
e.cause, we cannot know the root cause (was the error thrown bythrow1orthrow2?). This PR adds theerror.causeto relevant error reporting UI.Screenshots:
