Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GANG: Show error popup when there are errors #1763

Conversation

catloversg
Copy link
Contributor

This PR makes 2 changes:

  • Remove the useless check isNaN(numCycles):
    • process is only called from src\engine.tsx. I checked its callers. numCycles cannot be invalid.
    • If numCycles is invalid, that check only prints to the console without doing anything else. It's useless anyway.
  • When there are errors while processing gang data, show an error popup instead of printing to the console.

@d0sboots
Copy link
Collaborator

d0sboots commented Nov 11, 2024

Since this is a popup, won't it end up popping up every 200ms, thus making gameplay impossible?

I'm all for surfacing error messages better, but I feel like there needs to be a middle ground here.

@d0sboots d0sboots merged commit 5d26f4f into bitburner-official:dev Nov 11, 2024
5 checks passed
@d0sboots
Copy link
Collaborator

Great!

@catloversg catloversg deleted the pull-request/gang/show-error-popup-when-there-are-errors branch November 11, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants