Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V2.1.1 - Wordlists changed to v3.0.0 wordlists #141

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

harvmaster
Copy link

The JSON mnemonic word lists in LibAuth V2.1 use import someWordList from wordListFile assert { type: 'json' } which was an experimental JS feature. Recent versions of Rollup (which Vite uses) will no longer build with this syntax (causes unexpected token error).

This PR just updates the mnemonic word lists to the word list files used in V3.0.0 and updates the imports in bip39.ts accordingly.

This creates a very large diff (for each of the word files). It might just be easier to run the below commands to copy over on top of what I have in this PR to ensure no changes to the word lists relative to V3.0.0.

cd src/lib/key/word-lists

curl -o bip39.chinese-simplified.ts https://raw.githubusercontent.com/bitauth/libauth/v3.0.0/src/lib/key/word-lists/bip39.chinese-simplified.ts

curl -o bip39.chinese-traditional.ts https://raw.githubusercontent.com/bitauth/libauth/v3.0.0/src/lib/key/word-lists/bip39.chinese-traditional.ts

curl -o bip39.czech.ts https://raw.githubusercontent.com/bitauth/libauth/v3.0.0/src/lib/key/word-lists/bip39.czech.ts

curl -o bip39.english.ts https://raw.githubusercontent.com/bitauth/libauth/v3.0.0/src/lib/key/word-lists/bip39.english.ts

curl -o bip39.french.ts https://raw.githubusercontent.com/bitauth/libauth/v3.0.0/src/lib/key/word-lists/bip39.french.ts

curl -o bip39.italian.ts https://raw.githubusercontent.com/bitauth/libauth/v3.0.0/src/lib/key/word-lists/bip39.italian.ts

curl -o bip39.japanese.ts https://raw.githubusercontent.com/bitauth/libauth/v3.0.0/src/lib/key/word-lists/bip39.japanese.ts

curl -o bip39.korean.ts https://raw.githubusercontent.com/bitauth/libauth/v3.0.0/src/lib/key/word-lists/bip39.korean.ts

curl -o bip39.portuguese.ts https://raw.githubusercontent.com/bitauth/libauth/v3.0.0/src/lib/key/word-lists/bip39.portuguese.ts

curl -o bip39.spanish.ts https://raw.githubusercontent.com/bitauth/libauth/v3.0.0/src/lib/key/word-lists/bip39.spanish.ts

Copy link

changeset-bot bot commented Sep 1, 2024

⚠️ No Changeset found

Latest commit: 518d9a3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jimtendo
Copy link
Contributor

jimtendo commented Sep 1, 2024

On the framework side, the assert { type: 'json' } issue on V2.1 impacts Quasar (which uses Vite and rollup for its build command).

@bitjson bitjson force-pushed the master branch 3 times, most recently from e72ba49 to 60aec23 Compare November 13, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants