Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix outdated command "rebuild_cache" #156

Open
erikyao opened this issue Nov 1, 2022 · 1 comment
Open

fix outdated command "rebuild_cache" #156

erikyao opened this issue Nov 1, 2022 · 1 comment
Assignees

Comments

@erikyao
Copy link
Contributor

erikyao commented Nov 1, 2022

MyVariantHubServer::rebuild_cache method, defined in src/bin/hub.py#L67, uses a get_latest_build(build_name) function. However this function was removed in ecb98dd.

What's more, the build_name parameter seems to be a build_config name actually (e.g. "warm_hg19"). A new signature design is to remove the parameter build_name at all, with target being the target build name (e.g. "warm_hg19_20220127_fpgrwjzd"). The calling of self.managers["build_manager"].list_sources(build_name) can be replaced by reading src_build.<_id>.sources field.

@erikyao erikyao self-assigned this Nov 1, 2022
@erikyao
Copy link
Contributor Author

erikyao commented Nov 2, 2022

Decision after 11/01 BioThings Technical meetup: comment out the function and command definition temporarily.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant