Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] widget: Make controlAreaVisible a global setting #282

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ales-erjavec
Copy link
Collaborator

Issue

Make controlAreaVisible a global setting along the widget geometry.

Description of changes

Make controlAreaVisible a global setting

Includes
  • Code changes
  • Tests
  • Documentation

@codecov-commenter
Copy link

codecov-commenter commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.03%. Comparing base (c28fde3) to head (13e174b).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #282   +/-   ##
=======================================
  Coverage   72.03%   72.03%           
=======================================
  Files          34       34           
  Lines        9117     9117           
=======================================
  Hits         6567     6567           
  Misses       2550     2550           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@markotoplak
Copy link
Member

@ales-erjavec, thanks, this change means that now a newly added widget could be shown with a hidden control area. @janezd (and me) pointed out that for new widgets, the control area should always be shown. The size is problematic: if a default was saved with a hidden control area, the new widget size should be increased in width by the control area size.

@markotoplak markotoplak marked this pull request as draft December 23, 2024 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants