Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change log level for missing user properties #212

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

vgaidarji
Copy link

Fixes #204

What has been done

  • Missing apiKey/user error message log level change from info to error (see de1c3ce)
  • Ignored autogenerated project files
  • General code clean up (removed semicolons)

How to test

  • Set user or key to null in bintray closure:
bintray {
    user = null
    key = null
}
  • Execute ./gradlew clean build install bintrayUpload -DdryRun=true command and observe logs

Before the change

:dependencies-overview:build
:dependencies-overview:install
:dependencies-overview:bintrayUpload

BUILD SUCCESSFUL

After the change

:dependencies-overview:build
:dependencies-overview:install
:dependencies-overview:bintrayUpload
Skipping task 'dependencies-overview:bintrayUpload' because user or apiKey is null.

BUILD SUCCESSFUL

@CLAassistant
Copy link

CLAassistant commented Jun 18, 2020

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optionally fail if user/key not given
3 participants