Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no findmnt #189

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

no findmnt #189

wants to merge 4 commits into from

Conversation

ezrizhu
Copy link
Collaborator

@ezrizhu ezrizhu commented Jan 3, 2025

In the past we added the ability for try to go over findmnt's results and mount non-root directories that are mounts, however this doesn't allow their parent directory to be mounted without mergerfs, essentially rendering it useless.

This PR removes the code that uses findmnt, and also updates the docs and CI scripts to remove util-linux as that dep's only use was to provide findmnt.

@mgree
Copy link
Contributor

mgree commented Jan 10, 2025

Is dropping this enough to drop the util-linux dependency? If so, we should update the docs, packages, and CI scripts.

@ezrizhu ezrizhu requested a review from mgree January 10, 2025 23:09
@ezrizhu
Copy link
Collaborator Author

ezrizhu commented Jan 10, 2025

Is dropping this enough to drop the util-linux dependency? If so, we should update the docs, packages, and CI scripts.

done, and PR description updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants