Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Encode & Decode for Wrapping<T> types #686

Merged
merged 2 commits into from
Dec 15, 2023

Conversation

mzachar
Copy link
Contributor

@mzachar mzachar commented Dec 14, 2023

Structures can clearly indicate that the value may overflow and it is intended behaviour

@VictorKoenders
Copy link
Contributor

VictorKoenders commented Dec 14, 2023

I double checked serde's implementation (which matches your implementation, so you're good) and I noticed they also implement std::cmp::Reverse<T>. This is also a simple wrapper around T. Would you mind adding that as well?

Copy link

codecov bot commented Dec 14, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (3a638a7) 57.24% compared to head (8792100) 57.39%.

❗ Current head 8792100 differs from pull request most recent head 3847e54. Consider uploading reports for the commit 3847e54 to get more accurate results

Files Patch % Lines
src/de/impls.rs 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            trunk     #686      +/-   ##
==========================================
+ Coverage   57.24%   57.39%   +0.15%     
==========================================
  Files          51       51              
  Lines        4350     4366      +16     
==========================================
+ Hits         2490     2506      +16     
  Misses       1860     1860              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mzachar
Copy link
Contributor Author

mzachar commented Dec 14, 2023

I don't mind at all :)

@VictorKoenders VictorKoenders enabled auto-merge (squash) December 15, 2023 06:44
@VictorKoenders VictorKoenders merged commit 092628b into bincode-org:trunk Dec 15, 2023
41 of 74 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants