Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT: Add Neural Likelihood Estimation (NLE) likelihood #827

Draft
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

GregoryAshton
Copy link
Collaborator

This PR adds a method to utilise NLE within bilby

Summary of changes:

  1. Refactor the core/likelihood.py module into a set of submodules
  2. Add a module core/likelihood/simulation_based_inference.py

@GregoryAshton GregoryAshton changed the title Add Neural Likelihood Estimation (NLE) likelihood FEAT: Add Neural Likelihood Estimation (NLE) likelihood Oct 8, 2024
@mj-will mj-will added the enhancement New feature or request label Oct 9, 2024
@mj-will
Copy link
Collaborator

mj-will commented Oct 9, 2024

Hi @GregoryAshton, I haven't had a chance to look over this properly but it seems like a pretty big addition. Given that, I thought it might be worth discussing whether this should go into bilby or perhaps a downstream package?

My main concern is the additional maintenance burden from having code that depends on sbi. This seems somewhat opposite to what we've been doing with the samplers. What do you think?

Happy to discuss this on a call at some point.

@GregoryAshton
Copy link
Collaborator Author

@mj-will Yep, understood. This is just a draft at the moment. I wanted to make it public, and I can bring it up on a call to discuss and make others aware, but where it ultimately lives certainly needs some thought.

However, for now I can say that my intention (if it lives in Bilby) is to make it an optional dependency (which is why I refactored the likelihood to enable this). Right now I am mainly working on the implementation.

@mj-will mj-will marked this pull request as draft October 9, 2024 13:01
@mj-will
Copy link
Collaborator

mj-will commented Oct 9, 2024

@GregoryAshton sounds good. I've marked this as a draft for now, so it's clear you're still working on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants