-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEAT: Add Neural Likelihood Estimation (NLE) likelihood #827
base: main
Are you sure you want to change the base?
Conversation
Hi @GregoryAshton, I haven't had a chance to look over this properly but it seems like a pretty big addition. Given that, I thought it might be worth discussing whether this should go into My main concern is the additional maintenance burden from having code that depends on Happy to discuss this on a call at some point. |
@mj-will Yep, understood. This is just a draft at the moment. I wanted to make it public, and I can bring it up on a call to discuss and make others aware, but where it ultimately lives certainly needs some thought. However, for now I can say that my intention (if it lives in Bilby) is to make it an optional dependency (which is why I refactored the likelihood to enable this). Right now I am mainly working on the implementation. |
@GregoryAshton sounds good. I've marked this as a draft for now, so it's clear you're still working on this. |
…nto add-sbi-nle-likelihood
This PR adds a method to utilise NLE within bilby
Summary of changes:
core/likelihood.py
module into a set of submodules