Fix 31 - GridDividerItemDecoration crashes on drawVerticalDividers(...) #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given a grid where all rows are filled up to the end, the calculation for `rowCount` has been corrected by bringing back logic that was previously removed. Resolves: bignerdranch#31
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #31
A recent change to the vertical divider logic removed the check for
numChildrenOnLastRow. That caused a crash when the last row was full. I find this version of the calculation simpler than the old version and I think it fits better with the new logic of the method.I hope you do not mind adding the comment there - I spent quite a long time trying to figure out the purpose of some of the variables and I hope this comment helps future maintainers.
As with all contributions to foreign repos, I'm happy to change the styling to be consistent with your team so let me know what I should change.