Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GridDividerItemDecoration crashes on drawVerticalDividers(...) #31

Open
Mojtaba-Shafaei opened this issue Oct 20, 2017 · 2 comments
Open

GridDividerItemDecoration crashes on drawVerticalDividers(...) #31

Mojtaba-Shafaei opened this issue Oct 20, 2017 · 2 comments

Comments

@Mojtaba-Shafaei
Copy link

  • drawVerticalDividers crashes when I tested it with 8 items.

  • Would you support equal horizontal space in left and right of items?
@mobiRic mobiRic mentioned this issue Feb 28, 2018
Open
@mobiRic
Copy link

mobiRic commented Feb 28, 2018

From what I can see, a breaking change was introduced in commit 11a647f

The code in drawVerticalDividers() before that change works fine for me, and the new code crashes if leftMostChild is null.

@mobiRic mobiRic mentioned this issue Feb 28, 2018
Open
@mobiRic
Copy link

mobiRic commented Mar 2, 2018

@Mojtaba-Shafaei
I'm getting a crash where the number of items is an exact multiple of the number of columns i.e. for your 8 items I see a crash at 2 columns and 4 columns. Is this the same behaviour you are getting?

What do you mean by the equal spacing? Do you think that is the same as my issue #34 that I logged the other day?

mobiRic added a commit to mobiRic/simple-item-decoration that referenced this issue Mar 2, 2018
@mobiRic
Fix GLM vertical divider null view bug
d2ae551 
Given a grid where all rows are filled up to the end, the calculation for `rowCount` has been corrected by bringing back logic that was previously removed.

Resolves: bignerdranch#31
@mobiRic mobiRic mentioned this issue Mar 2, 2018
Open
TonyTangAndroid pushed a commit to TonyTangAndroid/itemDecoration that referenced this issue Dec 28, 2018
@mobiRic
Fix GLM vertical divider null view bug
7c34a06 
Given a grid where all rows are filled up to the end, the calculation for `rowCount` has been corrected by bringing back logic that was previously removed.

Resolves: bignerdranch#31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mobiRic @Mojtaba-Shafaei