Data model review and suggestions #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nealkruis
commented
Oct 21, 2024
Comment on lines
+62
to
+83
| maximum_refrigerant_temperature: # Was maximum_setpoint in HeatSourceConfiguration | ||
| Description: "Maximum temperature of the refrigerant entering the condenser" | ||
| Data Type: Numeric | ||
| Units: "K" | ||
| maximum_temperature: # Was maximum_temperature in HeatSourceConfiguration. # TODO: Remove and use performance map maximum grid temperature | ||
| Description: "Maximum external temperature" | ||
| Data Type: Numeric | ||
| Units: "K" | ||
| Required: False | ||
| minimum_temperature: # Was minimum_temperature in HeatSourceConfiguration. # TODO: Remove and use performance map minimum grid temperature | ||
| Description: "Minimum external temperature" | ||
| Data Type: Numeric | ||
| Units: "K" | ||
| Required: False | ||
| compressor_lockout_temperature_hysteresis: # Was hysteresis_temperature_difference in HeatSourceConfiguration | ||
| Description: "Hysteresis for compressor lockout" | ||
| Data Type: Numeric | ||
| Units: "K" | ||
| Required: False | ||
| Notes: | ||
| - "Compressor locks out when the evaporator environment temperature drops this much below the minimum operating temperature, and unlocks when the temperature rises this much above the minimum operating temperature" | ||
| - "Compressor locks out when the evaporator environment temperature rises this much above the maximum operating temperature, and unlocks when the temperature drops this much below the maximum operating temperature" |
nealkruis
commented
Oct 21, 2024
| Notes: | ||
| - "Compressor locks out when the evaporator environment temperature drops this much below the minimum operating temperature, and unlocks when the temperature rises this much above the minimum operating temperature" | ||
| - "Compressor locks out when the evaporator environment temperature rises this much above the maximum operating temperature, and unlocks when the temperature drops this much below the maximum operating temperature" | ||
| use_defrost_map: # TODO: Remove and add defrost de-rating into performance map |
There was a problem hiding this comment.
Can be done after discussions with standards committee.
nealkruis
commented
Oct 21, 2024
| Data Type: "[Numeric]" | ||
| Units: "W" | ||
| Required: True | ||
| cop: | ||
| Description: "Coefficient of performance (Nevap x Nsrc values)" | ||
| heating_capacity: |
There was a problem hiding this comment.
Priority one (convert COP to capacity)
nealkruis
commented
Oct 21, 2024
| @@ -113,6 +137,6 @@ CoilConfiguration: | |||
| WRAPPED: | |||
| Description: "Coil is wrapped around the tank interior" | |||
| Display Text: "Wrapped" | |||
| EXTERNAL: | |||
| EXTERNAL: # TODO: Remove after we have the air-to-water heat pump RS | |||
There was a problem hiding this comment.
Lower priority (along with air to water heat pump)
nealkruis
commented
Oct 21, 2024
| Description: "Weighted distribution of heat by division, in order" | ||
| Data Type: "[Numeric]" | ||
| Description: "Weighted distribution of heat from the heat source along the height of the tank" | ||
| Data Type: "{WeightedDistribution}" |
There was a problem hiding this comment.
Lower priority. Needs more design/discussion?
nealkruis
commented
Oct 21, 2024
| Data Type: "[{HeatingLogic}]" | ||
| Required: False | ||
| standby_logic: | ||
| standby_logic: # TODO: Is this needed? |
There was a problem hiding this comment.
Lower priority. Needs to be researched to understand what it is intended to represent.
There was a problem hiding this comment.
If turn-on condition true, and standbyLogic exists, defers to standbyLogic to engage. If turn-on condition true, and no standbyLogic exists, engages, equivalent to top-node turn-on logic (perviously undefined). However, no IHPWH models have defined standbyLogic; this feature is only used by Sanco models. Other instances may have been coding remnants and are now replaced.
There was a problem hiding this comment.
Might be worth asking Ben if this is something that we need to keep moving forward, or if there is a simpler way to get the same outcome.
nealkruis
commented
Oct 21, 2024
| Units: "K" | ||
| Required: False | ||
| is_vip: | ||
| is_vip: # TODO: We need to come up with a better name. Since there can only be one "VIP", we should maybe just reference it at the Performance data group |
nealkruis
commented
Oct 21, 2024
Comment on lines
+122
to
+140
| WeightedDistribution: | ||
| Object Type: "Data Group" | ||
| Data Elements: | ||
| normalized_height: | ||
| Description: "Normalized heights within the tank where the weight is defined between the bottom (0.0), and the top (1.0)" | ||
| Data Type: "[Numeric]" | ||
| Units: "-" | ||
| Constraints: | ||
| - ">= 0.0" | ||
| - "<= 1.0" | ||
| Required: True | ||
| weight: | ||
| Description: "Fraction of weight at the corresponding normalized height" | ||
| Data Type: "[Numeric]" | ||
| Units: "-" | ||
| Constraints: | ||
| - ">= 0.0" | ||
| - "<= 1.0" | ||
| Required: True |
nealkruis
commented
Oct 21, 2024
| Required: True | ||
|
|
||
| SoCBasedHeatingLogic: | ||
| StateOfChargeBasedHeatingLogic: # This probably needs some re-design to make it meaningful to a manufacturer |
There was a problem hiding this comment.
Re-design is lower priority.
nealkruis
commented
Oct 21, 2024
| Description: "Number of nodes used for simulation" | ||
| Data Type: "Integer" | ||
| Constrains: "> 0" | ||
| heat_exchanger_effectiveness: | ||
| heat_exchanger_effectiveness: # TODO: Move to separate RS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.