Update kiva #1
Open
Update kiva #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- CSE.exe can be found here: https://github.com/cse-sim/cse/actions/runs/2110440035 - Update seasonal heating probes reported in "Seasonal Temperatures.csv".
- Soil conductivity = 1.0 Btu/hr-ft-F (1.73 W/m-K) - Soil specific heat = 0.1 Btu/lb-F (419 J/kg-K) - Soil density = 115 lb/ft3 (1842.12 kg/m3) - These are all default values for each property in both CSE and EnergyPlus.
…and total building heating load. - Was previously reporting main zone infiltration load instead of basement. - Was previously reporting only main zone heating load, which explains low results for Section 7 cases with basement (L322, L324).
nealkruis
reviewed
Oct 14, 2022
base.pxt
Outdated
| @@ -940,11 +944,16 @@ EXPORT | |||
| EXPORTCOL colHead="Attic Cooling Seasonal Temp [F]" colVal=select(@rsysres["Main Zone HVAC System"].S.qcSen < 0, @znres["Attic Zone"].S.tAir * @rsysres["Main Zone HVAC System"].S.hrsOn, default 0) | |||
|
|
|||
| // Heating seasonal data | |||
| EXPORTCOL colHead="Rsysres Heating [Btu]" colVal=@rsysres["Main Zone HVAC System"].S.qh | |||
| EXPORTCOL colHead="Rsysres Heating Hours On [hr]" colVal=select(@rsysres["Main Zone HVAC System"].S.qh > 0, @rsysres["Main Zone HVAC System"].S.hrsOn ,default 0) | |||
| // EXPORTCOL colHead="Rsysres Heating [Btu]" colVal=@rsysres["Main Zone HVAC System"].S.qh | |||
There was a problem hiding this comment.
Is there a reason to comment this out instead of removing it entirely?
There was a problem hiding this comment.
In case heating seasonal energy is important for QAQC steps in the future. I could create a new header parameter to toggle this on/off instead.
nealkruis
reviewed
Oct 14, 2022
base.pxt
Outdated
| <% if foundation_type == "BASEMENT" %> | ||
| EXPORTCOL colHead="Basement Temp [F]" colVal=@znres["Basement Zone"].S.tAir | ||
| EXPORTCOL colHead="Basement Heating Seasonal Temp [F]" colVal=select(@rsysres["Main Zone HVAC System"].S.qh > 0, @znres["Basement Zone"].S.tAir * @rsysres["Main Zone HVAC System"].S.hrsOn, default 0) | ||
| // EXPORTCOL colHead="Basement Heating Seasonal Temp [F]" colVal=select(@rsysres["Main Zone HVAC System"].S.qh > 0, @znres["Basement Zone"].S.tAir * @rsysres["Main Zone HVAC System"].S.hrsOn, default 0) |
There was a problem hiding this comment.
Is there a reason to comment this out instead of removing it entirely?
There was a problem hiding this comment.
In case basement heating seasonal temperature is important for QAQC steps in the future. I could create a new header parameter to toggle this on/off instead.
- These outputs are used for seasonal DSE calculations related to ASHRAE Standard 152 - Replace outputs using S.qh (incorrect probe, used with @Ahres) with S.qhNet (correct probe, net total of all other heating probes) - Adjust indenting of last if/end block.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to CSE.exe with recent Kiva updates.
Make soil properties used by Kiva consistent with EnergyPlus test suite.
Fix reporting of basement infiltration load in Detailed exports file and total building heating load.