Skip to content

Commit

Permalink
Addressing Rubocop errors
Browse files Browse the repository at this point in the history
  • Loading branch information
johnhebron committed Sep 3, 2022
1 parent 0cd8578 commit fd06505
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 9 deletions.
16 changes: 9 additions & 7 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,18 +1,20 @@
## Next Release
Your contribution here.

* [#170](https://github.com/bigcommerce/bigcommerce-api-ruby/pull/170): Fix various Rubocop warnings and declare dotenv as a dev dependency - [@splittingred](https://github.com/splittingred)
* [#169](https://github.com/bigcommerce/bigcommerce-api-ruby/pull/169): Add frozen_string_literal magic comment to all files - [@splittingred](https://github.com/splittingred)
* [#168](https://github.com/bigcommerce/bigcommerce-api-ruby/pull/168): Move to CircleCI off of TravisCI - [@splittingred](https://github.com/splittingred)
* [#168](https://github.com/bigcommerce/bigcommerce-api-ruby/pull/168): Explicitly declare development dependencies in gemspec - [@splittingred](https://github.com/splittingred)
* [#173](https://github.com/bigcommerce/bigcommerce-api-ruby/pull/173): Loosen Faraday dependency to ~> 1.1.0 - [@bc-johnhebron](https://github.com/bc-johnhebron).
* [#159](https://github.com/bigcommerce/bigcommerce-api-ruby/pull/159): Added new missing fields for an order - [@ranjeetkumarkanaily](https://github.com/ranjeetkumarkanaily).
* [#171](https://github.com/bigcommerce/bigcommerce-api-ruby/pull/171): Fix various Rubocop warnings and declare dotenv as a dev dependency - [@splittingred](https://github.com/splittingred).
* [#170](https://github.com/bigcommerce/bigcommerce-api-ruby/pull/170): Add frozen_string_literal magic comment to all files - [@splittingred](https://github.com/splittingred).
* [#169](https://github.com/bigcommerce/bigcommerce-api-ruby/pull/169): Move to CircleCI off of TravisCI - [@splittingred](https://github.com/splittingred).
* [#168](https://github.com/bigcommerce/bigcommerce-api-ruby/pull/168): Explicitly declare development dependencies in gemspec - [@splittingred](https://github.com/splittingred).
* [#167](https://github.com/bigcommerce/bigcommerce-api-ruby/pull/167): Changes handling of HTTP response headers to handle lowercased titles. - [@bc-zachary](https://github.com/bc-zachary).
* [#000](https://github.com/bigcommerce/bigcommerce-api-ruby/pull/000): Brief description here. - [@username](https://github.com/username).

## 1.0.1

* [#148](https://github.com/bigcommerce/bigcommerce-api-ruby/pull/148): Loosen Faraday version dependency pin. Update license to explicit MIT. Fix Rubocop and Travis builds. - [@splittingred](https://github.com/splittingred)
* [#142](https://github.com/bigcommerce/bigcommerce-api-ruby/pull/142): Update Faraday gem version. Add support for OAuth SSL options. - [@pedelman](https://github.com/pedelman)
* [#136](https://github.com/bigcommerce/bigcommerce-api-ruby/pull/136): Added accept-encoding: gzip header. - [@adambilsing](https://github.com/adambilsing)
* [#148](https://github.com/bigcommerce/bigcommerce-api-ruby/pull/148): Loosen Faraday version dependency pin. Update license to explicit MIT. Fix Rubocop and Travis builds. - [@splittingred](https://github.com/splittingred).
* [#142](https://github.com/bigcommerce/bigcommerce-api-ruby/pull/142): Update Faraday gem version. Add support for OAuth SSL options. - [@pedelman](https://github.com/pedelman).
* [#136](https://github.com/bigcommerce/bigcommerce-api-ruby/pull/136): Added accept-encoding: gzip header. - [@adambilsing](https://github.com/adambilsing).
* [#128](https://github.com/bigcommerce/bigcommerce-api-ruby/pull/128): Added support for token generation for storefront login. - [@mattolson](https://github.com/mattolson).

## 1.0.0
Expand Down
2 changes: 1 addition & 1 deletion lib/bigcommerce/config.rb
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ def api_url
# @return [String]
#
def base_url
ENV[BC_API_ENDPOINT_ENV_KEY].to_s.empty? ? DEFAULTS[:base_url] : ENV[BC_API_ENDPOINT_ENV_KEY]
ENV[BC_API_ENDPOINT_ENV_KEY].to_s.empty? ? DEFAULTS[:base_url] : ENV.fetch(BC_API_ENDPOINT_ENV_KEY, nil)
end
end
end
1 change: 0 additions & 1 deletion lib/bigcommerce/resources/orders/order.rb
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,6 @@ class Order < Resource
property :store_default_currency_code
property :store_default_to_transactional_exchange_rate
property :tax_provider_id


def self.count(params = {})
get 'orders/count', params
Expand Down

0 comments on commit fd06505

Please sign in to comment.