Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevents calling hide tooltip if already destroyed. #2341

Merged
merged 3 commits into from
Oct 10, 2024
Merged

Prevents calling hide tooltip if already destroyed. #2341

merged 3 commits into from
Oct 10, 2024

Conversation

deepakjosp
Copy link
Contributor

@deepakjosp deepakjosp commented Oct 10, 2024 •
edited
Loading

Fixes #2340

Description

  • Prevents calling hide tooltip if already destroyed, calling hide on a destroyed instance was throwing a warning in jest test.
  • The removed props from the Dropdown component is no longer supported by Tippy, using those in the molecules was throwing warnings in the console.

Checklist

  • I have made corresponding changes to the documentation.
  • I have updated the types definition of modified exports.
  • I have verified the functionality in some of the neeto web-apps.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added proper data-cy and data-testid attributes.
  • I have added the necessary label (patch/minor/major - If package publish
    is required).

Reviewers

@neetodeploy neetodeploy bot temporarily deployed to neeto-ui-kpyu-pr-2341 October 10, 2024 11:35 Inactive
@deepakjosp
Copy link
Contributor Author

@josephmathew900 _a please review.

josephmathew900
josephmathew900 approved these changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@josephmathew900 josephmathew900 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josephmathew900 josephmathew900 added the patch Releases small requests or bug fixes. label Oct 10, 2024
@josephmathew900 josephmathew900 merged commit b5b1af0 into main Oct 10, 2024
1 check passed
@josephmathew900 josephmathew900 deleted the 2340-prevent-calling-hide-tooltip-if-the-already-destroyed branch October 10, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josephmathew900 josephmathew900 josephmathew900 approved these changes

Assignees

@josephmathew900 josephmathew900

Labels
patch Releases small requests or bug fixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prevent calling hide Tooltip if the already destroyed.
2 participants
@deepakjosp @josephmathew900