Introduces a better Modal popup for unsaved changes in Forms. #2285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…scard changes, save changes and close the alert.
…he new set of buttons.
… validations and refactored the queries and added one more extra field in the form.
…d continue is cled when there's an error in the form.
|
@AbhayVAshokan _a please review. |
AbhayVAshokan
approved these changes
Aug 14, 2024
There was a problem hiding this comment.
Functionality looks great.
@praveen-murali-ind _a: I think having two primary action buttons is too much. Can we convert one of them to another style? WDYT?
Current UI: style: danger
Other possibilities
Style: danger-text
Style: secondary
Style tertiary
Style: text
praveen-murali-ind
approved these changes
Aug 14, 2024
There was a problem hiding this comment.
LGTM. @AbhayVAshokan In this case, each button represents a distinct primary action. For consistency across Neeto, we typically use solid red buttons for danger actions.
praveen-murali-ind
deleted the
732-a-better-modalpop-for-unsaved-changes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/bigbinary/neeto-engineering-web/issues/732
Description
Checklist
I have made corresponding changes to the documentation.I have updated the types definition of modified exports.I have added properdata-cyanddata-testidattributes.patch/minor/major- If package publishis required).
Reviewers