-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduces a better Modal popup for unsaved changes in Forms. #2285
Introduces a better Modal popup for unsaved changes in Forms. #2285
Conversation
…scard changes, save changes and close the alert.
…he new set of buttons.
… validations and refactored the queries and added one more extra field in the form.
…d continue is cled when there's an error in the form.
@AbhayVAshokan _a please review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functionality looks great.
@praveen-murali-ind _a: I think having two primary action buttons is too much. Can we convert one of them to another style? WDYT?
Current UI: style: danger
Other possibilities
Style: danger-text
Style: secondary
Style tertiary
Style: text
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. @AbhayVAshokan In this case, each button represents a distinct primary action. For consistency across Neeto, we typically use solid red buttons for danger actions.
Fixes https://github.com/bigbinary/neeto-engineering-web/issues/732
Description
Checklist
I have made corresponding changes to the documentation.I have updated the types definition of modified exports.I have added properdata-cy
anddata-testid
attributes.patch
/minor
/major
- If package publishis required).
Reviewers