Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enables table column resizing by default. #2283

Merged
merged 2 commits into from
Aug 14, 2024

Conversation

deepakjosp
Copy link
Contributor

@deepakjosp deepakjosp commented Aug 13, 2024

Description

Checklist

  • I have made corresponding changes to the documentation.
  • I have updated the types definition of modified exports.
  • I have verified the functionality in some of the neeto web-apps.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added proper data-cy and data-testid attributes.
  • I have added the necessary label (patch/minor/major - If package publish
    is required).

Reviewers

@deepakjosp
Copy link
Contributor Author

@AbhayVAshokan _a please review.

Copy link
Member

@AbhayVAshokan AbhayVAshokan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@neetogit-bot neetogit-bot bot assigned deepakjosp and unassigned AbhayVAshokan Aug 13, 2024
@deepakjosp
Copy link
Contributor Author

@AbhayVAshokan I checked the issues you mentioned.

  1. Checkbox column is added by Antd. They let us to set columnWidth property in the config object, but setting that didn't fix the issue.
  2. NeetoForm has a custom handler for the onColumnUpdate prop which only considers the column order and that resets the width to the initial width of the columns. That needs to be fixed in NeetoForm. I'll create a ticket for that in NeetoForm.

Since there are no changes to be done in NeetoUI, let's merge the PR as we decided in the standup.

@AbhayVAshokan AbhayVAshokan merged commit 8747ea9 into main Aug 14, 2024
1 check passed
@AbhayVAshokan AbhayVAshokan deleted the 306-enable-table-column-resizing-by-default branch August 14, 2024 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Releases small requests or bug fixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants