Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for displaying tooltips for disabled buttons in NoData component #2252

Merged
merged 3 commits into from
Jul 15, 2024
Merged

Added support for displaying tooltips for disabled buttons in NoData component #2252

merged 3 commits into from
Jul 15, 2024

Conversation

gaagul
Copy link
Contributor

@gaagul gaagul commented Jul 15, 2024

Description

  • Added support for displaying tooltips for disabled buttons in NoData component

Checklist

  • I have made corresponding changes to the documentation.
  • I have updated the types definition of modified exports.
  • I have verified the functionality in some of the neeto web-apps.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added proper data-cy and data-testid attributes.
  • I have added the necessary label (patch/minor/major - If package publish
    is required).

Reviewers

@josephmathew900 _A

cc: @abilash-sajeev

@gaagul gaagul added the patch Releases small requests or bug fixes. label Jul 15, 2024
@neetodeploy neetodeploy bot temporarily deployed to neeto-ui-kpyu-pr-2252 July 15, 2024 14:18 Inactive
josephmathew900
josephmathew900 approved these changes Jul 15, 2024
View reviewed changes
Copy link
Contributor

@josephmathew900 josephmathew900 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josephmathew900 josephmathew900 merged commit 180604c into main Jul 15, 2024
1 check was pending
@josephmathew900 josephmathew900 deleted the 2240-tool-tip-for-no-data-buttons branch July 15, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josephmathew900 josephmathew900 josephmathew900 approved these changes

Assignees

@josephmathew900 josephmathew900

Labels
patch Releases small requests or bug fixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for displaying tooltips for disabled buttons in NoData component
2 participants
@gaagul @josephmathew900