Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the scrollbar color #2237

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

thomas-mathai
Copy link
Contributor

@thomas-mathai thomas-mathai commented Jul 1, 2024

Description

  • Fixed the scrollbar visibility issue in Tables

Checklist

  • I have made corresponding changes to the documentation.
  • I have updated the types definition of modified exports.
  • I have verified the functionality in some of the neeto web-apps.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added proper data-cy and data-testid attributes.
  • I have added the necessary label (patch/minor/major - If package publish
    is required).

Reviewers

Tested the scrollbar change in NeetoCal using Yalc

Screen.Recording.2024-07-01.at.3.14.02.PM.mov

@thomas-mathai thomas-mathai added the patch Releases small requests or bug fixes. label Jul 1, 2024
@thomas-mathai thomas-mathai marked this pull request as ready for review July 1, 2024 09:53
@thomas-mathai
Copy link
Contributor Author

@josephmathew900 _a Can you please check?

Copy link
Contributor

@josephmathew900 josephmathew900 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @thomas-mathai _a Please add a description and merge the PR.

@thomas-mathai thomas-mathai merged commit 8f21049 into main Jul 1, 2024
1 check passed
@thomas-mathai thomas-mathai deleted the 2236-fix-scrollbar-visibility-issue-on-table branch July 1, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Releases small requests or bug fixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix scrollbar visibility issue on Table
2 participants