Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added option to pass data-cy to accordion #2233

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

gaagul
Copy link
Contributor

@gaagul gaagul commented Jun 20, 2024

Description

  • Added option to pass data-cy to accordion

Checklist

- [ ] I have made corresponding changes to the documentation.

  • I have updated the types definition of modified exports.
  • I have verified the functionality in some of the neeto web-apps.
    - [ ] I have added tests that prove my fix is effective or that my feature works.
  • I have added proper data-cy and data-testid attributes.
  • I have added the necessary label (patch/minor/major - If package publish
    is required).

Reviewers

@josephmathew900 _A

@gaagul gaagul added the patch Releases small requests or bug fixes. label Jun 20, 2024
@gaagul gaagul marked this pull request as ready for review June 20, 2024 10:35
Copy link
Contributor

@josephmathew900 josephmathew900 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@josephmathew900 josephmathew900 merged commit 9cac1d5 into main Jun 24, 2024
1 check passed
@josephmathew900 josephmathew900 deleted the 2227-data-cy-for-accordion branch June 24, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Releases small requests or bug fixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add data-cy to Accordion component
2 participants