Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added ProgressBar component #2199

Merged
merged 4 commits into from
May 24, 2024
Merged

Added ProgressBar component #2199

merged 4 commits into from
May 24, 2024

Conversation

gaagul
Copy link
Contributor

@gaagul gaagul commented May 21, 2024 •
edited
Loading

Description

  • Added: a new component ProgressBar

Checklist

  • I have made corresponding changes to the documentation.
  • I have updated the types definition of modified exports.
  • I have verified the functionality in some of the neeto web-apps.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added proper data-cy and data-testid attributes.
  • I have added the necessary label (patch/minor/major - If package publish
    is required).

Reviewers

@gaagul _a

@gaagul gaagul added the minor Releases non-breaking noteworthy changes with backward compatible. label May 21, 2024
@neetodeploy neetodeploy bot temporarily deployed to neeto-ui-kpyu-pr-2199 May 21, 2024 19:10 Inactive
@gaagul gaagul marked this pull request as ready for review May 22, 2024 04:06
@neetodeploy neetodeploy bot temporarily deployed to neeto-ui-kpyu-pr-2199 May 22, 2024 04:06 Inactive
@gaagul
Copy link
Contributor Author

gaagul commented May 22, 2024

@josephmathew900 _A please review.

@neetogit-bot neetogit-bot bot assigned josephmathew900 and unassigned gaagul May 22, 2024
josephmathew900
josephmathew900 approved these changes May 23, 2024
View reviewed changes
Copy link
Contributor

@josephmathew900 josephmathew900 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gaagul _a Added a minor suggestion. Rest LGTM. After making the change please assign the PR to Praveen for UI review.

tests/ProgressBar.test.jsx Show resolved Hide resolved
@neetogit-bot neetogit-bot bot assigned gaagul and unassigned josephmathew900 May 23, 2024
@gaagul
Copy link
Contributor Author

gaagul commented May 23, 2024

@praveen-murali-ind _a Please review the UI.

@neetogit-bot neetogit-bot bot assigned praveen-murali-ind and unassigned gaagul May 23, 2024
praveen-murali-ind
praveen-murali-ind approved these changes May 24, 2024
View reviewed changes
Copy link
Contributor

@praveen-murali-ind praveen-murali-ind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 🎉

@praveen-murali-ind praveen-murali-ind merged commit 164772f into main May 24, 2024
1 check passed
@praveen-murali-ind praveen-murali-ind deleted the 2172-progress-bar branch May 24, 2024 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josephmathew900 josephmathew900 josephmathew900 approved these changes

@praveen-murali-ind praveen-murali-ind praveen-murali-ind approved these changes

Assignees

@praveen-murali-ind praveen-murali-ind

Labels
minor Releases non-breaking noteworthy changes with backward compatible.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build the Progress component
3 participants
@gaagul @josephmathew900 @praveen-murali-ind