Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added functionality for selecting all rows in multi-page table #2127

Merged
merged 10 commits into from
Mar 22, 2024
Merged

Added functionality for selecting all rows in multi-page table #2127

merged 10 commits into from
Mar 22, 2024

Conversation

sritabh
Copy link
Contributor

@sritabh sritabh commented Mar 19, 2024 •
edited
Loading

Description
Added: bulkSelectAllRowsProps for tables to allow selecting all rows for multipage tables

Checklist

  • I have made corresponding changes to the documentation.
    - [] I have updated the types definition of modified exports.
  • I have verified the functionality in some of the neeto web-apps.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added proper data-cy and data-testid attributes.
  • I have added the necessary label (patch/minor/major - If package publish
    is required).

Reviewers

@sritabh sritabh added the minor Releases non-breaking noteworthy changes with backward compatible. label Mar 21, 2024
@sritabh sritabh marked this pull request as ready for review March 21, 2024 06:18
@sritabh
Copy link
Contributor Author

sritabh commented Mar 21, 2024 •
edited
Loading

@josephmathew900 _a Please review
I have verified the changes in neetoForm.
I have also added the story for the new prop added.

josephmathew900
josephmathew900 approved these changes Mar 22, 2024
View reviewed changes
Copy link
Contributor

@josephmathew900 josephmathew900 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@josephmathew900 josephmathew900 merged commit 64fc38e into main Mar 22, 2024
1 check passed
@josephmathew900 josephmathew900 deleted the 2126-adds-functionality-for-selecting-all-rows-in-multi-page-table branch March 22, 2024 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josephmathew900 josephmathew900 josephmathew900 approved these changes

Assignees

@josephmathew900 josephmathew900

Labels
minor Releases non-breaking noteworthy changes with backward compatible.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add functionality for selecting all rows in multi-page table
3 participants
@sritabh @josephmathew900 @bot-bigbinary