Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional dropdown triggers #2115

Merged
merged 5 commits into from
Mar 11, 2024
Merged

Additional dropdown triggers #2115

merged 5 commits into from
Mar 11, 2024

Conversation

akkshaylawrence
Copy link
Contributor

@akkshaylawrence akkshaylawrence commented Mar 11, 2024 •
edited by josephmathew900
Loading

Description

  • Added: Additional dropdown triggers

Checklist

  • I have made corresponding changes to the documentation.
  • I have updated the types definition of modified exports.
  • I have verified the functionality in some of the neeto web-apps.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added proper data-cy and data-testid attributes.
  • I have added the necessary label (patch/minor/major - If package publish
    is required).

Reviewers

@akkshaylawrence akkshaylawrence added the patch Releases small requests or bug fixes. label Mar 11, 2024
@akkshaylawrence
Copy link
Contributor Author

@ajmaln _A please review.

@akkshaylawrence
Copy link
Contributor Author

@josephmathew900 _A please review.

@neetogit-bot neetogit-bot bot assigned josephmathew900 and unassigned ajmaln Mar 11, 2024
josephmathew900
josephmathew900 approved these changes Mar 11, 2024
View reviewed changes
Copy link
Contributor

@josephmathew900 josephmathew900 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@josephmathew900 josephmathew900 merged commit 00d82b8 into main Mar 11, 2024
1 check passed
@josephmathew900 josephmathew900 deleted the 2114-dropdown-trigger branch March 11, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josephmathew900 josephmathew900 josephmathew900 approved these changes

Assignees

@josephmathew900 josephmathew900

Labels
patch Releases small requests or bug fixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dropdown component does not support mouseover and click event at the same time.
4 participants
@akkshaylawrence @josephmathew900 @ajmaln @bot-bigbinary