Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for resize, suffix, prefix and sizing for textarea #2113

Merged
merged 4 commits into from
Mar 6, 2024
Merged

Added support for resize, suffix, prefix and sizing for textarea #2113

merged 4 commits into from
Mar 6, 2024

Conversation

praveen-murali-ind
Copy link
Contributor

@praveen-murali-ind praveen-murali-ind commented Mar 6, 2024 •
edited
Loading

Description

  • Added: support for resize, suffix, prefix and sizing for textarea.

@ajmaln _a Please review.

Checklist

  • I have made corresponding changes to the documentation.
  • I have updated the types definition of modified exports.
  • I have verified the functionality in some of the neeto web-apps.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added proper data-cy and data-testid attributes.
  • I have added the necessary label (patch/minor/major - If package publish
    is required).

Reviewers

@praveen-murali-ind praveen-murali-ind added the patch Releases small requests or bug fixes. label Mar 6, 2024
@ajmaln ajmaln closed this Mar 6, 2024
@ajmaln ajmaln reopened this Mar 6, 2024
ajmaln
ajmaln reviewed Mar 6, 2024
View reviewed changes
src/components/Textarea.jsx Outdated Show resolved Hide resolved
src/components/Textarea.jsx Outdated Show resolved Hide resolved
@neetodeploy neetodeploy bot temporarily deployed to neeto-ui-pr-2113 March 6, 2024 12:53 Inactive
@ajmaln
Copy link
Contributor

ajmaln commented Mar 6, 2024

@josephmathew900 _a Please review, the deployment is failing somehow - please check

@neetogit-bot neetogit-bot bot assigned josephmathew900 and unassigned ajmaln Mar 6, 2024
josephmathew900
josephmathew900 approved these changes Mar 6, 2024
View reviewed changes
Copy link
Contributor

@josephmathew900 josephmathew900 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@josephmathew900 josephmathew900 merged commit 89dd420 into main Mar 6, 2024
1 check passed
@josephmathew900 josephmathew900 deleted the 2102-textarea-improvements branch March 6, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajmaln ajmaln ajmaln left review comments

@josephmathew900 josephmathew900 josephmathew900 approved these changes

Assignees

@josephmathew900 josephmathew900

Labels
patch Releases small requests or bug fixes.
Projects
None yet
Milestone
No milestone
4 participants
@praveen-murali-ind @ajmaln @josephmathew900 @bot-bigbinary