Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced info Icon with Help icon in Label component #2094

Merged
merged 7 commits into from
Feb 28, 2024

Conversation

nitinprojects
Copy link
Contributor

@nitinprojects nitinprojects commented Feb 21, 2024

Description

Before

Screenshot 2024-02-15 at 5 47 48 PM

After

2a-after


Before

3-before

After

Screenshot 2024-02-21 at 11 32 00 PM

Checklist

- [ ] I have made corresponding changes to the documentation.
- [ ] I have updated the types definition of modified exports.

  • I have verified the functionality in some of the neeto web-apps.
    - [ ] I have added tests that prove my fix is effective or that my feature works.
    - [ ] I have added proper data-cy and data-testid attributes.
  • I have added the necessary label (patch/minor/major - If package publish
    is required).

Reviewers

@nitinprojects nitinprojects added the patch Releases small requests or bug fixes. label Feb 21, 2024
@nitinprojects
Copy link
Contributor Author

@akkshaylawrence _a Please review.

cc: @praveen-murali-ind

Copy link
Contributor

neetogit-bot bot commented Feb 22, 2024

@nitinprojects CI is red.

Copy link
Contributor

@akkshaylawrence akkshaylawrence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nitinprojects _a LGTM

@nitinprojects
Copy link
Contributor Author

@farhanlatheef _a Please review.

Copy link
Contributor

neetogit-bot bot commented Feb 26, 2024

@nitinprojects CI is red.

@josephmathew900
Copy link
Contributor

@nitinprojects _a

Please fix the eslint errors. Also, please assign the PR for review only when all the required checks have been passed.

image

@nitinprojects
Copy link
Contributor Author

@josephmathew900 _a Fixed the eslint errors. Please check.

Copy link
Contributor

@josephmathew900 josephmathew900 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@josephmathew900 josephmathew900 merged commit 9dcdcd0 into main Feb 28, 2024
1 check passed
@josephmathew900 josephmathew900 deleted the 2085-icon-changes branch February 28, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Releases small requests or bug fixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make Help icon as default icon in Label ocomponent
5 participants