Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TimePickerInput improvements. #2093

Merged
merged 20 commits into from
Feb 27, 2024
Merged

TimePickerInput improvements. #2093

merged 20 commits into from
Feb 27, 2024

Conversation

farhanlatheef
Copy link
Contributor

@farhanlatheef farhanlatheef commented Feb 21, 2024 •
edited
Loading

Description

  • Added: range prop to allow time range picking.
  • Added: Selected values will be available on onBlur.
  • Fixed: Error while string value is passed.

Checklist

  • I have made corresponding changes to the documentation.
  • I have updated the types definition of modified exports.
  • I have verified the functionality in some of the neeto web-apps.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added proper data-cy and data-testid attributes.
  • I have added the necessary label (patch/minor/major - If package publish
    is required).

Reviewers

@farhanlatheef farhanlatheef added the minor Releases non-breaking noteworthy changes with backward compatible. label Feb 22, 2024
@farhanlatheef farhanlatheef marked this pull request as ready for review February 22, 2024 09:25
@farhanlatheef
Copy link
Contributor Author

@josephmathew900 _a

josephmathew900
josephmathew900 reviewed Feb 25, 2024
View reviewed changes
Copy link
Contributor

@josephmathew900 josephmathew900 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@farhanlatheef _a Added some suggestions, please check.

package.json Show resolved Hide resolved
src/styles/components/_date-time-picker.scss Outdated Show resolved Hide resolved
src/components/TimePickerInput/index.jsx Outdated Show resolved Hide resolved
tests/TimePickerInput.test.jsx Show resolved Hide resolved
index.d.ts Outdated Show resolved Hide resolved
@neetogit-bot neetogit-bot
Copy link
Contributor

neetogit-bot bot commented Feb 26, 2024

@farhanlatheef CI is red.

@farhanlatheef
Copy link
Contributor Author

@josephmathew900 _a

josephmathew900
josephmathew900 approved these changes Feb 27, 2024
View reviewed changes
Copy link
Contributor

@josephmathew900 josephmathew900 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@farhanlatheef _a Added a minor suggestion. Rest LGTM. Please make the change and merge the PR.

src/components/TimePickerInput/index.jsx Show resolved Hide resolved
@farhanlatheef farhanlatheef merged commit b2922d7 into main Feb 27, 2024
1 check passed
@farhanlatheef farhanlatheef deleted the 2090-timepicker-improvments branch February 27, 2024 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josephmathew900 josephmathew900 josephmathew900 approved these changes

Assignees

@farhanlatheef farhanlatheef

Labels
minor Releases non-breaking noteworthy changes with backward compatible.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Limitations of new TimePickerInput
3 participants
@farhanlatheef @josephmathew900 @bot-bigbinary