Remove sort_by from table query params (#2088)

* remove sort by from table query params * fix the failing tests --------- Co-authored-by: bot-bigbinary <[email protected]>
bigbinary · Feb 22, 2024 · b50149f · b50149f
1 parent 2adcd27
commit b50149f
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/components/Table/hooks/useTableSort.js b/src/components/Table/hooks/useTableSort.js
@@ -14,7 +14,7 @@ const useTableSort = () => {
 
   const handleTableChange = (pagination, sorter) => {
     const params = {
-      sort_by: sorter.order && camelToSnakeCase(sorter.field),
+      sort_by: sorter.order ? camelToSnakeCase(sorter.field) : undefined,
       order_by: URL_SORT_ORDERS[sorter.order],
       page: pagination.current,
     };

diff --git a/tests/Table.test.jsx b/tests/Table.test.jsx
@@ -182,7 +182,7 @@ describe("Table", () => {
     await userEvent.click(pages[2]);
     const queryParams = getQueryParams();
 
-    expect(queryParams).toEqual({ page: "2", sort_by: "" });
+    expect(queryParams).toEqual({ page: "2" });
   });
 
   it("should navigate to previous page if all the items in the last page are deleted", () => {
@@ -196,7 +196,7 @@ describe("Table", () => {
       />
     );
 
-    expect(getQueryParams()).toEqual({ page: "3", sort_by: "" });
+    expect(getQueryParams()).toEqual({ page: "3" });
 
     const handlePageChange = jest.fn();
     render(