Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added the hyphenate function #28

Merged
merged 3 commits into from
Dec 8, 2023
Merged

Added the hyphenate function #28

merged 3 commits into from
Dec 8, 2023

Conversation

allenjiji
Copy link
Contributor

@allenjiji allenjiji commented Dec 7, 2023 •
edited
Loading

Checklist

  • I have made corresponding changes to the documentation
  • I have verified the generated JSDoc comments
  • I have updated the types definition of modified exports
  • I have added jest tests for newly added changes
  • I have verified the functionality in some of the neeto web-apps.

@allenjiji
Copy link
Contributor Author

Closing the PR as we have https://github.com/bigbinary/neeto-commons-frontend/blob/main/docs/utils/hyphenize.md

@allenjiji allenjiji closed this Dec 8, 2023
@allenjiji allenjiji reopened this Dec 8, 2023
@allenjiji
Copy link
Contributor Author

Reopened as decided to move the function from neeto-commons-frontend to neeto-cist.

@allenjiji allenjiji added the patch Releases small requests or bug fixes. label Dec 8, 2023
@allenjiji
Copy link
Contributor Author

@ajmaln _a Please review

@ajmaln ajmaln merged commit e7e65f2 into main Dec 8, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajmaln ajmaln ajmaln approved these changes

Assignees

@ajmaln ajmaln

Labels
patch Releases small requests or bug fixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add hyphenate function
2 participants
@allenjiji @ajmaln