Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cypress #26

Merged
merged 1 commit into from
Dec 1, 2023
Merged

Remove cypress #26

merged 1 commit into from
Dec 1, 2023

Conversation

farhanlatheef
Copy link
Contributor

Checklist

- [ ] I have made corresponding changes to the documentation
- [ ] I have verified the generated JSDoc comments
- [ ] I have updated the types definition of modified exports
- [ ] I have added jest tests for newly added changes
- [ ] I have verified the functionality in some of the neeto web-apps.

@farhanlatheef
Copy link
Contributor Author

Cypress has string-width version dependency of "4.2.3", when we remove cypress we get latest version of string-width which is not correclty pointing to its cjs dir. solution is to add a resolution. Let me know if you want me to investigate more why latest version is not properly working. I think this sufficient now.

@ajmaln _a

@ajmaln ajmaln merged commit dbebf85 into main Dec 1, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Removing cypress from package is causing test failures
2 participants