Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] publish notes of the TownHall #459

Merged
merged 5 commits into from
Sep 13, 2024
Merged

[ENH] publish notes of the TownHall #459

merged 5 commits into from
Sep 13, 2024

Conversation

Remi-Gau
Copy link
Contributor

@Remi-Gau Remi-Gau commented Jul 26, 2024

data/beps/beps.yml Outdated Show resolved Hide resolved
- 'Persperctive: Start merging of stand-alone parts of the BEP (i.e., neuronavigation)'
- 'Persperctive: Collaboration with common NIBS software (BEST toolbox, simNIBS, K-space…)'
- 'Persperctive: Apply for funds for pushing forward the BEP'
- Updated BEP structure that eliminates new `.json` or `.tsv`
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update on NIBS BEP

data/beps/beps.yml Outdated Show resolved Hide resolved
os.environ["OPEN_CITATIONS_ACCESS_TOKEN"] = "/home/remi/Documents/tokens/open_citations_access_token.txt"
os.environ["OPEN_CITATIONS_ACCESS_TOKEN"] = (
"/home/remi/Documents/tokens/open_citations_access_token.txt"
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how big is the token -- should we place it into secrets and automate this on CI?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in any case -- IMHO better to use some env var and not hardcode paths (or evil yarik would login and steal that exact file!)

Co-authored-by: Yaroslav Halchenko <[email protected]>
@Remi-Gau Remi-Gau marked this pull request as ready for review September 13, 2024 06:31
@Remi-Gau Remi-Gau merged commit a662269 into main Sep 13, 2024
4 of 5 checks passed
@Remi-Gau Remi-Gau deleted the enh/455 branch September 13, 2024 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants