Skip to content

Commit

Permalink
[ENH] automatically open external links in a new tab - closes #414
Browse files Browse the repository at this point in the history
  • Loading branch information
Remi-Gau committed Jun 14, 2024
1 parent e9393b8 commit 5c9b609
Show file tree
Hide file tree
Showing 8 changed files with 21 additions and 21 deletions.
5 changes: 2 additions & 3 deletions data/beps.yml
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,7 @@
- name: ' '
email:
status:
- BEP is open to new leadership, see also [BEP032 (animal electrophys)](https://docs.google.com/document/d/1oG-C8T-dWPqfVzL2W8HO3elWK8NIh2cOCPssRGv23n0/){:target="_blank"}
- BEP is open to new leadership, see also [BEP032 (animal electrophys)](https://docs.google.com/document/d/1oG-C8T-dWPqfVzL2W8HO3elWK8NIh2cOCPssRGv23n0/)
blocking:
- Searching for a new leader.
google_doc_created: 2018-04
Expand Down Expand Up @@ -308,8 +308,7 @@
- 'New BEP, seeking contributors and collecting community feedback relating to: priority sequences to support, best supported binary structured formats
(e.g. CBOR? HDF5? MsgPack?).'
- Comments may be submitted directly on the document.
- Generating example datasets [here](https://github.com/JAgho/MISP_plot/tree/main){:target="_blank"} and determining best practice with vendors to
record data in-sequence
- Generating example datasets [here](https://github.com/JAgho/MISP_plot/tree/main) and determining best practice with vendors to record data in-sequence
blocking:
google_doc_created: 2021-04
pull_request_created:
Expand Down
6 changes: 3 additions & 3 deletions data/beps_other.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
content:
- raw
status:
- Became the [File mapper](https://github.com/DCAN-Labs/file-mapper){:target="_blank"}.
- Became the [File mapper](https://github.com/DCAN-Labs/file-mapper).

- number: '019'
title: DICOM Metadata
Expand All @@ -45,8 +45,8 @@
content:
- metadata
status:
- Closed in favor of possible direct support of DICOM within BIDS (see this [issue](https://github.com/bids-standard/bids-specification/issues/1552){:target="_blank"}
and this [pull request](https://github.com/bids-standard/bids-specification/pull/1551){:target="_blank"}).
- Closed in favor of possible direct support of DICOM within BIDS (see this [issue](https://github.com/bids-standard/bids-specification/issues/1552)
and this [pull request](https://github.com/bids-standard/bids-specification/pull/1551)).
google_doc_created: 2017-10
pull_request_created:
pull_request_merged:
Expand Down
18 changes: 9 additions & 9 deletions docs/bep/index.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,32 +3,32 @@
<u>Neurostars Website</u>

- The easiest way to contribute to BIDS is to ask questions you have about the specification on
[Neurostars](https://neurostars.org){:target="_blank"}.
[Neurostars](https://neurostars.org).
- If your question has a
[bids tag](https://neurostars.org/search?q=tags%3Abids){:target="_blank"}
[bids tag](https://neurostars.org/search?q=tags%3Abids)
it will be much easier for others to find the answer.
- You can also get involved by _answering_ questions on
[Neurostars](https://neurostars.org/search?q=tags%3Abids){:target="_blank"}!
[Neurostars](https://neurostars.org/search?q=tags%3Abids)!

<u>Github Issues</u>

- You can contribute to the BIDS specification by opening
[Issues](https://github.com/bids-standard/bids-specification/issues){:target="_blank"}
[Issues](https://github.com/bids-standard/bids-specification/issues)
and proposing changes via
[Pull Requests](https://github.com/bids-standard/bids-specification/pulls){:target="_blank"}
[Pull Requests](https://github.com/bids-standard/bids-specification/pulls)
on
[GitHub](https://github.com/bids-standard/bids-specification){:target="_blank"}.
[GitHub](https://github.com/bids-standard/bids-specification).
- To make improvements to the website that you are reading right now, you can also open an
[Issue](https://github.com/bids-standard/bids-website/issues){:target="_blank"}
[Issue](https://github.com/bids-standard/bids-website/issues)
and propose changes via Pull Requests at the
[BIDS website GitHub repository](https://github.com/bids-standard/bids-website){:target="_blank"}.
[BIDS website GitHub repository](https://github.com/bids-standard/bids-website).

<u> Become a part of the BIDS Community </u>

There are so many ways to help us build this community.

- You could help someone else learn the benefits of BIDS by giving a talk in your local organization
- Or you could work on [building a BIDS App](https://bids-apps.neuroimaging.io/){:target="_blank"}!
- Or you could work on [building a BIDS App](https://bids-apps.neuroimaging.io/)!

<b>The only requirement is that everyone who contributes adheres to our
[BIDS Code of Conduct](https://github.com/bids-standard/bids-specification/blob/master/CODE_OF_CONDUCT.md).</b>
Expand Down
1 change: 1 addition & 0 deletions mkdocs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ plugins:
# categories:
# - categories
# - tags
- open-in-new-tab

This comment has been minimized.

Copy link
@yarikoptic

yarikoptic Jun 14, 2024

Contributor

frankly I prefer to leave it up to the user to decide on either he needs yet another tab to add to his 100 already open...

This comment has been minimized.

Copy link
@yarikoptic

yarikoptic Jun 14, 2024

Contributor

modern browsers make it trivial to open a link in a new tab (unless it is some JS mumbo jumbo onclick)

- macros:
module_name: macros/main
- redirects:
Expand Down
1 change: 1 addition & 0 deletions requirements.in
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,4 @@ mkdocs-macros-plugin
mkdocs-redirects
ruamel.yaml
faqtory
mkdocs-open-in-new-tab
4 changes: 3 additions & 1 deletion requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ idna==3.7
# via requests
jinja2==3.1.4
# via
# -r requirements.in
# faqtory
# mkdocs
# mkdocs-macros-plugin
Expand All @@ -64,6 +63,7 @@ mkdocs==1.6.0
# via
# mkdocs-macros-plugin
# mkdocs-material
# mkdocs-open-in-new-tab
# mkdocs-redirects
# mkdocs-rss-plugin
mkdocs-get-deps==0.2.0
Expand All @@ -74,6 +74,8 @@ mkdocs-material==9.5.21
# via -r requirements.in
mkdocs-material-extensions==1.3.1
# via mkdocs-material
mkdocs-open-in-new-tab==1.0.3
# via -r requirements.in
mkdocs-redirects==1.2.1
# via -r requirements.in
mkdocs-rss-plugin==1.12.2
Expand Down
2 changes: 1 addition & 1 deletion templates/beps_table_md.jinja
Original file line number Diff line number Diff line change
Expand Up @@ -9,5 +9,5 @@
| :--------: | :---- | :----- | :----- | :---------- |
{% endif %}
{% for bep in include %}
| [BEP {{ bep.number }}]({{ bep.link }}){:target="_blank"} | {% if bep.display %} {{ bep.display }} {% else %} {{ bep.title }} {% endif %} | {% for content in bep.content %} {{ content }} {% endfor %} | {% for person in bep.leads %} {% if person.email %} [{{ person.name }}](mailto:{{ person.email }}) {% else %} {{ person.name }} {% endif %}<br>{% endfor %} | {% for item in bep.status %} - {{ item }} <br>{% endfor %} |
| [BEP {{ bep.number }}]({{ bep.link }}) | {% if bep.display %} {{ bep.display }} {% else %} {{ bep.title }} {% endif %} | {% for content in bep.content %} {{ content }} {% endfor %} | {% for person in bep.leads %} {% if person.email %} [{{ person.name }}](mailto:{{ person.email }}) {% else %} {{ person.name }} {% endif %}<br>{% endfor %} | {% for item in bep.status %} - {{ item }} <br>{% endfor %} |
{% endfor %}
5 changes: 1 addition & 4 deletions tools/convert_posts.py
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,7 @@
# for line in content:

# if frontmatter_done:
# f.write(
# line.replace('{:target:"_blank"}', "").replace(
# '{:target="_blank"}', ""
# )
# f.write(line)
# )
# continue

Expand Down

0 comments on commit 5c9b609

Please sign in to comment.