Allow to apply skip and limit parameters on the cursor count operation #399
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I figured out that even when backed by an index, the count operation will still have to scan every matched index key when used with a query. This can lead to performance issues when counting on large collection (for pagination for example).
To mitigate these issues the MongoDB shell allow to pass a
applySkipLimit
boolean parameter to thecursor.count()
method to apply theskip
andlimit
parameters of the cursor to the count operation. This way the count will stop when reaching the limit (which is often fine for pagination, as we rarely need to scroll until the last pages).The goal of this PR is to add this parameter to the
count
method of theMongoCursor
class in order to reflect the contract of the MongoDB shell method.cc @Dayde