feat(tests): Run test cases based on features #980
Conversation
|
Maybe we should deprecate the whole |
tests/appender.go
Outdated
| path := uuid.NewString() | ||
| o, err := store.CreateAppend(path) | ||
| f := store.Features() | ||
| if f.CreateAppend && f.WriteAppend && f.CommitAppend && f.Write && f.Read && f.Delete && f.Stat { |
There was a problem hiding this comment.
Maybe we should only check CreateAppend here and check the needed features when we use them so we can check as many cases as possible.
Got it. Do we just keep one source file, or keep the existing files? |
We can move them all into And we can organize other tests into different files for easy maintenance. |
|
Do you think it's a big burden to remove all deprecated test cases from services? Can we just remove them? |
If we remove them directly, we need to remove the test functions called in services before releasing a new version. Maybe we can do it together in #986? |
|
Got it. Let's revisit this PR until we figure out what's the best way to organize those tests based on features. |
ref: #966