feat: Support args in ls #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xuanwo
reviewed
Nov 13, 2021
cmd/byctl/ls.go
Outdated
| isFirst = false | ||
| isFirstSrc := true | ||
| for { | ||
| index, value, _ := reflect.Select(cases) |
There was a problem hiding this comment.
I think we have introduced too much complex logic (and even reflect) to support the calculation of total size and count.
How about support a callback in so.ListWithCallback(path, fn func(o *types.Object))?
And maybe we can refactor the whole cmd package in the futher.
|
Looks so nice now! |
Xuanwo
approved these changes
Nov 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #107