feat(admin): 3259 - Donner les droits apres la fin de la date d'instruction aux référents #4524
+40
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naustra
force-pushed
the
feat/block-instruction
branch
from
d748327
to
656702e
Compare
naustra
changed the title
naustra
changed the title
naustra
changed the title
achorein
reviewed
Nov 13, 2024
| @@ -43,7 +43,7 @@ export default function Index({ ...props }) { | |||
| ? "correction" | |||
| : "readonly"; | |||
| const cohort = cohorts.find(({ _id, name }) => _id === young?.cohortId || name === young?.cohort); | |||
| if (user.role !== ROLES.ADMIN && new Date() > new Date(cohort?.instructionEndDate || "")) { | |||
| if (![ROLES.ADMIN, ROLES.REFERENT_REGION].includes(user.role) && new Date() > new Date(cohort?.instructionEndDate || "")) { | |||
There was a problem hiding this comment.
il devrait aussi avoir un contrôle du côté de l'api pour empêcher la modification en fonction des droits.
Co-authored-by: Anselme Chorein <[email protected]>
…e à jour des imports
…s en fonction de la date d'instruction
achorein
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Donner les droits aux ref reg apres la date de fin d'instruction
https://www.notion.so/jeveuxaider/Bloquer-les-droits-d-instructions-des-ref-dep-apr-s-la-date-d-instruction-6d49b41713bf4378923e09a253b12d8c?pvs=4