Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api,admin): 3565 - Ajout d'une page Historique de la classe #4496

Merged
merged 23 commits into from
Nov 8, 2024

Conversation

C2Chandelier
Copy link
Collaborator

@C2Chandelier C2Chandelier commented Oct 29, 2024

api/src/referent/referentController.ts Outdated Show resolved Hide resolved
admin/src/scenes/classe/view/Details.tsx Show resolved Hide resolved
api/src/controllers/young/index.ts Outdated Show resolved Hide resolved
api/src/controllers/mission.js Outdated Show resolved Hide resolved
api/src/controllers/structure.js Outdated Show resolved Hide resolved
Copy link

codeclimate bot commented Oct 30, 2024

Code Climate has analyzed commit cd63523 and detected 10 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 5
Duplication 5

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 46.2% (0.2% change).

View more on Code Climate.

admin/src/scenes/classe/view/Inscriptions.tsx Outdated Show resolved Hide resolved
@@ -712,12 +712,70 @@ const translateFieldContract = (f) => {
}
};

export const translateFieldClasse = (f) => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

export const translateFieldClasse = (field: RouteResponse<ClassesRoutes["GetOne"]>) => {
ça le fait non ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

euh je suis dans admin la faut que j'aille le chercher dans l'api ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

normalement c'est dans packages/lib

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bien vu ! mais pour les array (exemple grades), j'ai des champ en entrée du type grades/0 ou grades/1 qui ne vont pas etre reconnu comme une reponse de la route GetOne

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok j'ai typé par keyof ClasseType ca me paraissait plus logique ?

api/src/cle/classe/classeController.ts Outdated Show resolved Hide resolved
api/src/controllers/application.js Outdated Show resolved Hide resolved
api/src/controllers/mission.js Outdated Show resolved Hide resolved
api/src/cle/young/youngController.ts Outdated Show resolved Hide resolved
api/src/cle/young/youngController.ts Outdated Show resolved Hide resolved
api/src/controllers/young/index.ts Outdated Show resolved Hide resolved
api/src/referent/referentController.ts Outdated Show resolved Hide resolved
@C2Chandelier C2Chandelier added this pull request to the merge queue Nov 8, 2024
Merged via the queue into main with commit 6b63e53 Nov 8, 2024
13 checks passed
@C2Chandelier C2Chandelier deleted the 3565-historic branch November 8, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants