-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api,admin): 3565 - Ajout d'une page Historique de la classe #4496
Conversation
Code Climate has analyzed commit cd63523 and detected 10 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 46.2% (0.2% change). View more on Code Climate. |
@@ -712,12 +712,70 @@ const translateFieldContract = (f) => { | |||
} | |||
}; | |||
|
|||
export const translateFieldClasse = (f) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
export const translateFieldClasse = (field: RouteResponse<ClassesRoutes["GetOne"]>) => {
ça le fait non ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
euh je suis dans admin la faut que j'aille le chercher dans l'api ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
normalement c'est dans packages/lib
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bien vu ! mais pour les array (exemple grades), j'ai des champ en entrée du type grades/0 ou grades/1 qui ne vont pas etre reconnu comme une reponse de la route GetOne
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok j'ai typé par keyof ClasseType ca me paraissait plus logique ?
https://www.notion.so/jeveuxaider/Cr-er-un-historique-de-classe-action-de-la-classe-12672a322d50806a8650eb3024f195f5?pvs=4
https://www.notion.so/jeveuxaider/Cr-er-un-historique-des-statuts-d-inscription-des-l-ves-suivi-du-statut-des-l-ves-11372a322d5080d195cbfec80436a5dc?pvs=4
Pour tester : brancher sur les données de prod car on ne garde pas les patches en staging (ou DB local si vous avez les patches)