Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(admin): 3539 - Filtrer sur la liste des volontaires d’un PDR d’une ligne de bus depuis le PDT #4493

Merged
merged 8 commits into from
Nov 12, 2024

Conversation

achorein
Copy link
Collaborator

@achorein achorein commented Oct 28, 2024

Description

image

Todo

  • Déplacer le compteur de jeune en bas de la carte de PDR et le entre clickable (View/components/PointDeRassemblement.tsx)
  • Modifier la requete de count des jeunes pour garder la cohérence (src/controllers/planDeTransport/ligne-de-bus.js)
  • Passage en TS des composants associés à la vue

Ticket / Issue

https://www.notion.so/jeveuxaider/Filtrer-sur-la-liste-des-volontaires-d-un-PDR-d-une-ligne-de-bus-depuis-le-PDT-12072a322d5080a18295c16210afe3f1?pvs=23

Testing instructions

@achorein achorein added WIP Work In Progress R&R labels Oct 28, 2024
@achorein achorein self-assigned this Oct 28, 2024
@achorein achorein marked this pull request as ready for review October 30, 2024 10:53
Copy link

codeclimate bot commented Oct 30, 2024

Code Climate has analyzed commit e2c16d2 and detected 13 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 13

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 46.0% (0.0% change).

View more on Code Climate.

Copy link
Collaborator

@Eric013 Eric013 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@achorein achorein added this pull request to the merge queue Nov 12, 2024
Merged via the queue into main with commit 56403b6 Nov 12, 2024
13 checks passed
@achorein achorein deleted the feat/pdr-list-by-bus branch November 12, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
R&R WIP Work In Progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants