Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): 3556 - MAJ de l'import de PDR (uniquement par matricule) #4472

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

achorein
Copy link
Collaborator

Description

Adapatation de l'import pour ne plus prendre en compte l'id temporaire (on se base maintenant uniquement sur les matricule pour les maj)

Todo

  • Suppression du mapping par "id"
  • Se base uniquement sur le matricule pour l'import

Ticket / Issue

https://www.notion.so/jeveuxaider/Importer-le-PDR-12272a322d5080f387f6f136cae02e68?pvs=23

Testing instructions

@achorein achorein added the R&R label Oct 21, 2024
@achorein achorein self-assigned this Oct 21, 2024
@achorein achorein changed the title feat(api): MAJ de l'import de PDR (uniquement par matricule) feat(api): 3556 - MAJ de l'import de PDR (uniquement par matricule) Oct 21, 2024
Copy link

codeclimate bot commented Oct 21, 2024

Code Climate has analyzed commit dbf4569 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 46.0% (0.0% change).

View more on Code Climate.

Copy link
Collaborator

@Eric013 Eric013 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@Eric013 Eric013 force-pushed the feat/import-pdr-bymatricule branch 2 times, most recently from 6900a00 to 8f51825 Compare November 13, 2024 15:30
Copy link
Collaborator Author

@achorein achorein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants