-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(api): poc eligibility add tests #4317
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achorein
force-pushed
the
chore/test-eligibility
branch
2 times, most recently
from
September 13, 2024 14:11
96762fd
to
ddbd9b0
Compare
achorein
force-pushed
the
chore/test-eligibility
branch
4 times, most recently
from
September 16, 2024 15:15
3ca2194
to
7eb6ddc
Compare
achorein
force-pushed
the
chore/test-eligibility
branch
7 times, most recently
from
September 20, 2024 07:09
52e6336
to
6581c91
Compare
achorein
force-pushed
the
chore/test-eligibility
branch
from
September 23, 2024 07:57
3d0c707
to
b1796ed
Compare
achorein
commented
Sep 23, 2024
app/src/scenes/account/scenes/general/components/ChangeAddressModal/index.jsx
Outdated
Show resolved
Hide resolved
achorein
force-pushed
the
chore/test-eligibility
branch
from
September 24, 2024 14:54
d055593
to
21a9141
Compare
nicobret
reviewed
Sep 25, 2024
achorein
force-pushed
the
chore/test-eligibility
branch
from
September 30, 2024 13:38
21a9141
to
feaa3fb
Compare
nicobret
approved these changes
Sep 30, 2024
@hlecourt ok pour toi ? |
achorein
force-pushed
the
chore/test-eligibility
branch
from
October 14, 2024 08:23
e95dcc1
to
ef9e854
Compare
achorein
force-pushed
the
chore/test-eligibility
branch
from
October 14, 2024 09:28
84d5d83
to
0061ff1
Compare
achorein
force-pushed
the
chore/test-eligibility
branch
from
October 14, 2024 12:21
0061ff1
to
bcf8779
Compare
Code Climate has analyzed commit ed90d09 and detected 8 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 45.6% (0.3% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Améliore la maintenabilité et ajout des tests d'intégration sur les différents cas du POC d'eligibilité par département #4291
Todo
/cohort-session/eligibility/2023
utils/cohort
en TSCas spécifique
Dates de naissance
Niveaux scolaires
Eligibilité - Zones géographiques
Paramètres dynamiques
Ticket / Issue
https://www.notion.so/jeveuxaider/Tests-op-rations-Eligibilit-ge-niveau-scolaire-et-zone-g-ographique-99285155b36f4295b86282ced93356b0
Testing instructions